Skip to content

Build the GitHub Action with the repo's Node - #1380

Merged
epompeii merged 1 commit into
develfrom
u/ep/release-action-node
Oct 28, 2026
Merged

epompeii merged 1 commit into
develfrom
u/ep/release-action-node

Conversation

@epompeii

Copy link
Copy Markdown
Member

The Build GitHub Action job now builds with the repo's Node, through the setup-node composite (Node 26, npm ci). Before, it ran npm install --include=dev on the default Node of the runner (22, with npm 10). That npm removes the "libc" entries that the committed services/action/package-lock.json has, so Check for changes found a diff.

On branches that step is continue-on-error, so the drift was hidden. On tags it is strict, so every tag run failed and the Release job was skipped.

  • npm ci never writes the lockfile, so Check for changes now checks only the built dist/.
  • I checked the v0.6.14 release commit: Node 22 and Node 20 reproduce the 4 "libc" removals. Node 26 with npm ci gives no diff, and the built dist/index.js does not change.

@epompeii
epompeii marked this pull request as ready for review October 28, 2026 00:52
@epompeii
epompeii merged commit 72a8549 into devel Oct 28, 2026
37 of 38 checks passed
@epompeii
epompeii deleted the u/ep/release-action-node branch October 28, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant